Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Textures] New index and 32 bit texture support article #124

Merged
merged 6 commits into from
Aug 4, 2024

Conversation

muczc1wek
Copy link
Contributor

@muczc1wek muczc1wek commented Jun 21, 2024

docs/zengin/textures.md Outdated Show resolved Hide resolved
docs/zengin/textures.md Outdated Show resolved Hide resolved
docs/zengin/textures.md Outdated Show resolved Hide resolved
docs/zengin/textures.md Outdated Show resolved Hide resolved
@muczc1wek muczc1wek requested a review from kamilkrzyskow June 22, 2024 17:50
@muczc1wek muczc1wek changed the title [Textures] New main article [Textures] New index and 32 bit texture support article Jun 23, 2024
@auronen
Copy link
Collaborator

auronen commented Jul 2, 2024

We could add a link to GRM Blogpost about mipmaps, it demonstrates it well.

@kamilkrzyskow
Copy link
Collaborator

OK, I'll have a look

docs/zengin/textures/32bit_texture.md Outdated Show resolved Hide resolved
docs/zengin/textures/32bit_texture.md Outdated Show resolved Hide resolved
docs/zengin/textures/32bit_texture.md Show resolved Hide resolved
- Uncheck `Generate Mipmaps` if your texture is meant to be used as UI.
- Set the `Colorspace` to `BGRA8888 (zEnum:3)` or other supported format.
4. Press `Save` and check your texture in-game:
![Ingame Example](../../assets/images/EXAMPLE_INGAME.WEBP)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In-game

Also modify the images that are too big with attr_list.
Example from Union Getting Started {: style='min-width: 0;' }
Or something similar

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which images are too big?

Copy link
Collaborator

@kamilkrzyskow kamilkrzyskow Jul 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed this notification, probably got merged with the other message.

Which images are too big?

Those that take up too much vertical sapce on my 1080p monitor and don't have fine details that require the bigger size🤔So this is yet another subjective issue hmm. So you can keep the sizing for now as is. I'll think about a more general CSS change, as currently the issue is the min-width: 75% in the .md-content img override. Small images explode in size to keep the aspect ratio.

If you want, you can also play around with it, removing that min-width, and replace it with a combination of min-height, max-height using rem values. Like:

min-height: 8rem;
max-height: 20rem;

but perhaps there is no optimal solution for this, and some images will still have to be adjusted with attr_list.
If you decide to change the CSS, be sure to check other pages with images like C_ITEM, VDPS, Spacer 👌

docs/zengin/textures/32bit_texture.md Outdated Show resolved Hide resolved
docs/zengin/textures/index.md Outdated Show resolved Hide resolved
docs/zengin/textures/index.md Outdated Show resolved Hide resolved
docs/zengin/textures/index.md Show resolved Hide resolved
docs/zengin/textures/32bit_texture.md Outdated Show resolved Hide resolved
docs/zengin/textures/32bit_texture.md Outdated Show resolved Hide resolved
@muczc1wek muczc1wek requested a review from kamilkrzyskow July 24, 2024 11:43
@muczc1wek muczc1wek merged commit 674ee2b into Gothic-Modding-Community:dev Aug 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants