Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Textures] New index and 32 bit texture support article #124
[Textures] New index and 32 bit texture support article #124
Changes from 4 commits
c287b6a
d62b347
8a8ee2e
76e31fb
166a97e
38213e1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In-game
Also modify the images that are too big with attr_list.
Example from Union Getting Started
{: style='min-width: 0;' }
Or something similar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which images are too big?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed this notification, probably got merged with the other message.
Those that take up too much vertical sapce on my 1080p monitor and don't have fine details that require the bigger size🤔So this is yet another subjective issue hmm. So you can keep the sizing for now as is. I'll think about a more general CSS change, as currently the issue is the
min-width: 75%
in the.md-content img
override. Small images explode in size to keep the aspect ratio.If you want, you can also play around with it, removing that min-width, and replace it with a combination of min-height, max-height using
rem
values. Like:but perhaps there is no optimal solution for this, and some images will still have to be adjusted with attr_list.
If you decide to change the CSS, be sure to check other pages with images like C_ITEM, VDPS, Spacer 👌