-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to localize the application #246
base: dev
Are you sure you want to change the base?
Conversation
I have updated all the strings to use a key instead of the English translation. The French translation has also been updated to match this change and fix some display issues. |
7326039
to
54bc129
Compare
@theboringhumane , are you setting up some AI review bot? 🤩 |
I built it lol |
It seems to be an authentication / pipeline issue for Cori, right? Or did I do something wrong? |
Yes action was for that only. |
cfa1263
to
3d55c90
Compare
The app is already localizable, no need to change texts, Xcode handles it. |
One commit earlier does the translation in French without changing all the texts. |
Following a feature request on Discord, to add Chinese language to the app, I looked into how to support different languages.
I have added a localization for French as well.
Changes are in
For now there is apparently no conflicting keys, however in the future it may be interesting to refactor the code to add "backend" names to each string depending on where they're used.