Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to localize the application #246

Open
wants to merge 77 commits into
base: dev
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
77 commits
Select commit Hold shift + click to select a range
b9616dc
Placeholder provided by media player
overflow-sudo Nov 3, 2024
07c540c
rewrite logic for detirmining when to change album art and when to us…
Alexander5015 Nov 5, 2024
ee9a937
Hide mini app icon when app icon is being used for artwork
Alexander5015 Nov 5, 2024
f8feb8a
Use the isPlaying function rather than guessing based on playback rat…
Alexander5015 Nov 7, 2024
db082e7
adjust states inside thread for new playing detection
Alexander5015 Nov 7, 2024
67184f6
Update bundle identifier logic for more accurate icon
Alexander5015 Nov 7, 2024
b56f9d6
allow timeline to update while paused, for the case when the back ski…
Alexander5015 Nov 7, 2024
cb02d44
More fixes
Alexander5015 Nov 7, 2024
d7b64c6
modify screen lock monitoring
Alexander5015 Nov 18, 2024
a2db151
temporary fix for repositioning problems
Alexander5015 Nov 18, 2024
1cb0152
Changed selectedScreen to preferredScreen and added a seperate select…
Alexander5015 Nov 18, 2024
77ed09c
Add a Default Key and settings for show on all displays
Alexander5015 Nov 18, 2024
d6b8825
Add all displays as a beta feature
Alexander5015 Nov 19, 2024
fb0454f
Dynamically change settings views based on preferences and fix deprec…
Alexander5015 Nov 17, 2024
f080019
Better sneak peek logic for song change and ignoring empty entries
Alexander5015 Nov 20, 2024
da41032
update timeline slider logic for better behaviour when paused
Alexander5015 Nov 20, 2024
b1417f0
Refactor the code by transferring certain elements from BoringViewMod…
Alexander5015 Nov 21, 2024
dd0189a
Use new BoringView Coordinator, refactor matters.swift and sizes, and…
Alexander5015 Nov 21, 2024
a64982d
Move BoringViewCoordinator into folder
Alexander5015 Nov 21, 2024
f15cbb0
Add the option to customize the size of the notch window on notched s…
Alexander5015 Nov 21, 2024
f993014
settings resize changes
Alexander5015 Nov 21, 2024
6c1580b
add opactity and blur to NotchHomeView
Alexander5015 Nov 21, 2024
d061455
🦦 Dr. OtterAI Code Review, PhD
theboringhumane Dec 18, 2024
a242d6a
Fix syntax error
theboringhumane Dec 18, 2024
18a6cb4
Issue here remove for now
theboringhumane Dec 18, 2024
fe5cb1f
Added Blur Effect to Text when expanding Notch
OmChachad Nov 22, 2024
c8b942c
Added Matched Geometry Effect to Spectrum
OmChachad Nov 22, 2024
4a570ed
Added Blur Effect to Notch Opening
OmChachad Nov 22, 2024
d6d7a49
Notch Open Animation Updated to Mimic iOS Behavior
OmChachad Nov 22, 2024
f9f9465
Improved Animations
OmChachad Nov 22, 2024
47b0414
Reduced Blur Spread to Prevent Interference with Physical Notch
OmChachad Nov 22, 2024
51c3b41
Fixed Uneven Corner Radii, Added Continous Radius
OmChachad Nov 22, 2024
c70e344
Reduced Blur Delay
OmChachad Nov 22, 2024
929fd04
Added Safe Area for Hover Zone
OmChachad Nov 22, 2024
cfdf360
Removed Excess Horizontal Padding, Corner Radius now matches.
OmChachad Nov 23, 2024
a318851
Artwork now shrinks when paused
OmChachad Nov 23, 2024
769517d
Improved Slider Responsiveness
OmChachad Nov 23, 2024
ab00919
Reduced Padding between Song Name and Artist Name
OmChachad Nov 23, 2024
7e26cbf
Increased Play Button Size
OmChachad Nov 23, 2024
88460e2
Added Move Transition and Enhanced Blur Effect
OmChachad Nov 23, 2024
4169cf7
Revert "Added Move Transition and Enhanced Blur Effect"
OmChachad Nov 23, 2024
1a37432
Placeholder provided by media player
overflow-sudo Nov 3, 2024
7e0f475
rewrite logic for detirmining when to change album art and when to us…
Alexander5015 Nov 5, 2024
524d80f
Modify MusicSliderView to display hours if applicable
Alexander5015 Nov 5, 2024
fd5dd70
Hide mini app icon when app icon is being used for artwork
Alexander5015 Nov 5, 2024
f9e55f8
Use the isPlaying function rather than guessing based on playback rat…
Alexander5015 Nov 7, 2024
4aef50c
Prevent crashes due to non-finite duration
Alexander5015 Nov 7, 2024
aaddd84
Remove old debug print statements
Alexander5015 Nov 7, 2024
86058f3
adjust states inside thread for new playing detection
Alexander5015 Nov 7, 2024
08ff0b6
Update bundle identifier logic for more accurate icon
Alexander5015 Nov 7, 2024
96019ae
allow timeline to update while paused, for the case when the back ski…
Alexander5015 Nov 7, 2024
ea5e59c
More fixes
Alexander5015 Nov 7, 2024
b4a8094
added shortcut ability to toggle notch open
freepicheep Nov 7, 2024
60e3ad4
modify screen lock monitoring
Alexander5015 Nov 18, 2024
bcc5fe6
Changed selectedScreen to preferredScreen and added a seperate select…
Alexander5015 Nov 18, 2024
c035401
Add a Default Key and settings for show on all displays
Alexander5015 Nov 18, 2024
1518305
Add all displays as a beta feature
Alexander5015 Nov 19, 2024
ed6b855
Dynamically change settings views based on preferences and fix deprec…
Alexander5015 Nov 17, 2024
beab22e
Refactor the code by transferring certain elements from BoringViewMod…
Alexander5015 Nov 21, 2024
dc4aa8e
Use new BoringView Coordinator, refactor matters.swift and sizes, and…
Alexander5015 Nov 21, 2024
438d89e
Move BoringViewCoordinator into folder
Alexander5015 Nov 21, 2024
f288959
Add the option to customize the size of the notch window on notched s…
Alexander5015 Nov 21, 2024
c64188e
Fixed Compiling Error
OmChachad Nov 24, 2024
db2988a
Further Enhancements to Blur Animation
OmChachad Nov 24, 2024
ee4ea14
Fixed Runtime Error
OmChachad Nov 29, 2024
3dfbb3b
✨ CoriAI Code Review
theboringhumane Dec 19, 2024
aefd824
Use cori-ai App
theboringhumane Dec 19, 2024
0a70dd0
Update cori-ai 🤖 version
theboringhumane Dec 19, 2024
13d4265
✨ CoriAI Code Reviewer
theboringhumane Dec 20, 2024
a3b5748
Update Settings view to support localization
grumlu Dec 17, 2024
3481e18
Started moving to keys for strings
grumlu Dec 18, 2024
60bb640
Updated strings to have keys instead of english
grumlu Dec 18, 2024
3d55c90
Improved translataion, fixed badges
grumlu Dec 18, 2024
fca1784
Merge branch 'main' into dev
theboringhumane Dec 20, 2024
c1b1a0d
Updated guidelines
theboringhumane Dec 22, 2024
e36bd76
Merge branch 'dev' into feature/localization
grumlu Dec 22, 2024
c55ef1f
Merge branch 'TheBoredTeam:main' into feature/localization
grumlu Dec 31, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 78 additions & 0 deletions .github/workflows/code-review.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,78 @@
name: ✨ CoriAI Code Review

on:
pull_request:
types: [opened, synchronize, reopened]
paths-ignore:
- '**.md'
- 'LICENSE'
- '.gitignore'

jobs:
cori-ai-review:
runs-on: ubuntu-latest
permissions:
contents: read
pull-requests: write
actions: read
issues: write
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0 # Required to get full history for better context

- name: Cori Auth Step
id: generate-token
uses: actions/create-github-app-token@v1
with:
app-id: ${{ secrets.CORI_APP_ID }}
private-key: ${{ secrets.CORI_APP_PRIVATE_KEY }}

- name: ✨ CoriAI Code Review, PhD
uses: theboringhumane/cori-ai@1.2.10 # Uses the action from the current repository
with:
openai_api_key: ${{ secrets.OPENAI_API_KEY }}
openai_base_url: ${{ secrets.OPENAI_BASE_URL }}
github_token: ${{ steps.generate-token.outputs.token }}
model: 'gpt-4o-mini'
extra_prompt: |
Please focus on:
You are a senior Swift/SwiftUI developer reviewing pull requests for the BoringNotch macOS application. This app customizes the MacBook notch area with
various features like music controls and visualizer, calendar, camera mirror.
When reviewing PRs, consider the following key aspects:
1. Project Structure Compliance
Verify new files follow the established directory structure as defined
Ensure file naming follows conventions
2. Dependencies Management
Check if new dependencies are properly added to the Package.resolved file
Verify minimum deployment target compatibility (macOS 14.2+)
3. Code Quality Standards
Verify compliance with SwiftLint rules
Check proper access control usage (private, fileprivate, internal, public)
Ensure documentation for public APIs
Verify proper error handling implementation
Check for memory management best practices
4. MacOS Specific Considerations
Verify proper entitlements usage
Check privacy permissions declarations
Ensure compatibility with notch-specific APIs
Verify proper window management for notch area
Review Checklist
Does the code follow the project's architectural patterns?
Does the PR include proper documentation?
Are there any potential performance issues?
Does the code handle edge cases and error conditions?
Is the UI implementation consistent with existing design patterns?
Are accessibility features properly implemented?
Does the code handle system events and state changes appropriately?
Are there any potential memory leaks?
Does the PR include appropriate changelog entries?
IMPORTANT GUIDELINES
- Mandatory to Use emojis in your comments add code examples as well with your comments (markdown format)
- Do not repeat the commit message or description or what user is doing right, just point out issues and things which can be improved. Do not bombard with too much comments.
7 changes: 4 additions & 3 deletions boringNotch/ContentView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -157,10 +157,10 @@ struct ContentView: View {
.sensoryFeedback(.alignment, trigger: haptics)
.contextMenu {
SettingsLink(label: {
Text("Settings")
Text("common.settings")
})
.keyboardShortcut(KeyEquivalent(","), modifiers: .command)
Button("Edit") {
Button("common.edit") {
let dn = DynamicNotch(content: EditPanelView())
dn.toggle()
}
Expand Down Expand Up @@ -196,7 +196,7 @@ struct ContentView: View {
if vm.expandingView.type == .battery && vm.expandingView.show && vm.notchState == .closed {
HStack(spacing: 0) {
HStack {
Text("Charging")
Text("battery.charging")
.font(.subheadline)
}

Expand Down Expand Up @@ -303,6 +303,7 @@ struct ContentView: View {
)
.frame(width: 16, height: 12)
}
.matchedGeometryEffect(id: "spectrum", in: albumArtNamespace)
} else {
LottieAnimationView()
.frame(maxWidth: .infinity, maxHeight: .infinity)
Expand Down
Loading