New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[audit] #9: Clarify comment on renewal pricing #54

Merged

stevieraykatz merged 1 commit into main from cantina#9

Jul 9, 2024

Collaborator

stevieraykatz commented Jun 25, 2024

From Spearbit:

Description
This assumes that the premium is 0 which relies on two facts:

Currently you can only renew a token on BaseRegistrar before the grace period ends
The current implementation of the IPriceOracle uses the elapsed time after the grace period ends and thus it returns 0 for premium before that.

Recommendation
The above should be documented more in the NatSpec. Currently it is only mentioned that:

    ///     The price for renewal never incorporates pricing `premium`. Use the `base` price returned by the `rentPrice`
    ///     tuple to determine the price for calling this method.


          Clarify comment on renewal pricing

7bdb407

stevieraykatz added the Informational label

stevieraykatz merged commit ddaadc4 into main

1 of 3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels