Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[audit] #9: Clarify comment on renewal pricing #54

Merged
merged 1 commit into from
Jul 9, 2024
Merged

[audit] #9: Clarify comment on renewal pricing #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/L2/RegistrarController.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,8 +443,9 @@ contract RegistrarController is Ownable {
/// @notice Allows a caller to renew a name for a specified duration.
///
/// @dev This `payable` method must receive appropriate `msg.value` to pass `_validatePayment()`.
/// The price for renewal never incorporates pricing `premium`. Use the `base` price returned by the `rentPrice`
/// tuple to determine the price for calling this method.
/// The price for renewal never incorporates pricing `premium`. This is because we only expect
/// renewal on names that are not expired or are in the grace period. Use the `base` price returned
/// by the `rentPrice` tuple to determine the price for calling this method.
///
/// @param name The name that is being renewed.
/// @param duration The duration to extend the expiry, in seconds.
Expand Down