-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: AWS codebuild: Avoid branch names like main~3
.
#919
docs: AWS codebuild: Avoid branch names like main~3
.
#919
Conversation
|
Thanks for your PR! Please change your commit message to start with If you have a public example using your amended AWS Codebuild workflow successfully running, that would be very helpful for review. See https://github.com/cypress-io/cypress-example-kitchensink/blob/master/README.md#ci-workflow-examples
I don't know why the CircleCI Pipeline is failing. That would need to be looked at by the Cypress.io team who have access to the CircleCI account. |
fdea6f1
to
c28e7e5
Compare
…h has advanced compared to current commit. Fixes `main~3` to become `main` instead.
c28e7e5
to
8da1c0a
Compare
You should probably also change the title of the PR
as well. ( |
main~3
for AWS codebuildmain~3
.
Changed commit message and PR title. I even had some brackets wrong in the code, which I have now fixed. I don't have a public workflow available. The changes are somewhat testable in a shell, when "mocking" the output of
Prints:
|
When the main branch has advanced compared to the currently checked out commit,
git name-rev
will print e.g.main~3
.To keep Cypress branch names clean, we want
COMMIT_INFO_BRANCH
to be justmain
, though.Therefore, I suggest cutting off the suffix.
If this gets merged, I believe the docs have to be afterwards updated in multiple places, too, e.g. here: https://github.com/cypress-io/cypress-documentation/blob/main/docs/app/continuous-integration/aws-codebuild.mdx
I could do that, too, if desired, but of course don't have an overview of all the correct places.