Explicitly depend on fb_sysfs in fb_storage #240
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I spun up a new class of GCE VM which uses NVMe-based storage, but fb_storage failed, complaining about being unable to find fb_sysfs. After digging into it a bit, I noticed that fb_storage doesn't explicitly depend on `fb_sysfs`, despite using it in several places, [like when configuring nvme-based storage](https://github.com/facebook/chef-cookbooks/blob/c64381a2e0195855703f59a001a64a589ae1ac73/cookbooks/fb_storage/resources/format_devices.rb#L169). I verified that simply adding `depends_on fb_sysfs` was enough to resolve the error.
russtaylor
requested review from
jaymzh,
joshuamiller01 and
davide125
as code owners
jaymzh
approved these changes
Jul 29, 2024
|
LGTM - I'll wait for someone internal to pull it internally. |
|
@dafyddcrosby has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request has been merged in 27a816a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spun up a new class of GCE VM which uses NVMe-based storage, but fb_storage failed, complaining about being unable to find fb_sysfs. After digging into it a bit, I noticed that fb_storage doesn't explicitly depend on
fb_sysfs, despite using it in several places, like when configuring nvme-based storage.I verified that simply adding
depends 'fb_sysfs'was enough to resolve the error.