global: Fixes strings marked for translation. #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removes superfluous white space. - Adjust field to look like other fields. Refs: inveniosoftware/invenio-app-rdm#1707
kpsherva
reviewed
Jun 23, 2022
Comment on lines
+93
to
+94
| label={i18next.t("New unique identifier of the community")} | ||
| placeholder={i18next.t("New unique identifier of the community")} |
There was a problem hiding this comment.
could you show us how does it look like (screenshot)? I am not sure if the field label should be the same as a placeholder
There was a problem hiding this comment.
Popup shown when clicking here on "Change identifier"
There was a problem hiding this comment.
I thought it might be unique to other places like this:
and this
however, both of them aren't pop-ups.
kpsherva
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: inveniosoftware/invenio-app-rdm#1707