Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global: Fixes strings marked for translation. #724

Merged
merged 1 commit into from
Jun 28, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -179,5 +179,5 @@ MembersSearchBar.propTypes = {
};

MembersSearchBar.defaultProps = {
placeholder: i18next.t("Search ..."),
placeholder: i18next.t("Search..."),
};
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,8 @@ export class RenameCommunitySlugButton extends Component {
<Modal.Content>
<Form onSubmit={this.handleChange}>
<Form.Input
label={i18next.t("Enter the new unique identifier of the community.")}
label={i18next.t("New unique identifier of the community")}
placeholder={i18next.t("New unique identifier of the community")}
Comment on lines +93 to +94
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you show us how does it look like (screenshot)? I am not sure if the field label should be the same as a placeholder

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Popup shown when clicking here on "Change identifier"
image

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it might be unique to other places like this:
image
and this
image
however, both of them aren't pop-ups.

fluid
input={{ ref: this.formInputRef }}
{...(error
Expand Down