Updated bazel target to include silicon test #25765
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engdoreis
reviewed
Jan 9, 2025
There was a problem hiding this comment.
@rprakas-gsc, thanks for the PR.
Could you please edit the commit message in order to make the "Signed-off" line the last one? This will be consistent with all the commits in the repo.
| { | ||
| "//hw/top_earlgrey:sim_verilator": None, | ||
| "//hw/top_earlgrey:fpga_cw340_sival": None, | ||
| "//hw/top_earlgrey:silicon_creator": None, |
There was a problem hiding this comment.
I think that his exec_env is only meant to be used by the ROM_EXT and some manufacture tests.
@timothytrippel can you please confirm?
There was a problem hiding this comment.
@engdoreis Thanks for the comments. Made the changes to the commit message!
Updated bazel target to include silicon tests for aes_interrupt_encryption tests Signed-off-by: Ramesh Prakash <rprakas@google.com>
rprakas-gsc
force-pushed
the
earlgrey_1.0.0
branch
from
e2f8167 to
a7214ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ramesh Prakash rprakas@google.com
Updated bazel target to include silicon tests for aes_interrupt_encryption tests