Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python-sdk): remove client side validation from python sdk #457

Conversation

GMorris-professional
Copy link
Contributor

This PR removes all traces of client side validation from the Python SDK. This excludes validation of required keys but rather focuses on validation of the attributes of the values themselves (e.g. maxLength, minLength etc.)

Description

  • Removed all contents of hasValidation block in config/clients/python/template/model.mustache
  • Removed all contents of hasValidation block in config/clients/python/template/src/api.py.mustache
  • Removed all traces of disabled_client_side_validations from config/clients/python/template/src/configuration.py.mustache
  • Removed assertions and tests for disabled_client_side_validations from config/clients/python/template/test/configuration_test.py.mustache

References

openfga/sdk-generator#450

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

If you haven't done so yet, we would appreciate it if you could star the OpenFGA repository. :)

@GMorris-professional GMorris-professional requested a review from a team as a code owner November 30, 2024 09:46
@GMorris-professional GMorris-professional force-pushed the feat/remove-client-side-validation-python-sdk branch from d4c6341 to 2815df0 Compare November 30, 2024 09:54
@GMorris-professional GMorris-professional changed the title feat: remove client side validation from python sdk feat(python-sdk): remove client side validation from python sdk Nov 30, 2024
Copy link
Member

@rhamzeh rhamzeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @GMorris-professional!

@rhamzeh rhamzeh added this pull request to the merge queue Dec 2, 2024
Merged via the queue into openfga:main with commit 7e3ed38 Dec 2, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants