wt_axi_adapter: Fix addr width parametrisation #2697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ successful run, report available here. |
|
@paulsc96 you need to sign the Eclipse ECA agreement to become contributor |
|
✔️ successful run, report available here. |
…nsions Co-authored-by: Paul Scheffler <paulsc@iis.ee.ethz.ch> Signed-off-by: Nils Wistoff <nwistoff@iis.ee.ethz.ch>
|
@JeanRochCoulon I squashed the commits. the ECA check passes now |
|
✔️ successful run, report available here. |
|
Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1571 zero-extended the
paddrs to match theaxi_addrwidth and thus fix lint warnings. However, this breaks elaboration ifAxiAddrWidth <= PLEN. To fix lint warnings without breaking parametrisation, use explicit casts to pad/truncate as required.