-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ad_advs.R #96
Update ad_advs.R #96
Conversation
The CHG and PCHG derivations were restricted to the post-baselines visits using restrict_derivation() with AVISITN > 0 condition as in the referenced #2484 in pharmaverse/admiral repository.
Thanks @remikk - the code change looks good to me. You now need to work through the above PR checklist ticking them all off, e.g. update PR title to include "closes #<issue_number>" and add a sentence to the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good ! Please apply Ross' comments and it will be ready to finalize this PR.
Hi @Fanny-Gautier and @rossfarrugia |
…ost-baseline-records-only
…ost-baseline-records-only
…e-records-only' of https://github.com/pharmaverse/admiralpeds into 95-restrict-computation-of-chg-and-pchg-to-post-baseline-records-only
Dear @Fanny-Gautier, @rossfarrugia, all |
…ost-baseline-records-only
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NEWS.md
and templates/ad_advs.R
well updated, Website well produced without any error
Now approved, I will merge the Branch. Thanks @remikk for all the updates! ✨ |
Closes #96
The CHG and PCHG derivations were restricted to the post-baselines visits using restrict_derivation() with AVISITN > 0 condition as in the referenced #2484 in pharmaverse/admiral repository.
Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.
Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the
main
branch until you have checked off each task.styler::style_file()
to style R and Rmd filesdevtools::document()
so all.Rd
files in theman
folder and theNAMESPACE
file in the project root are updated appropriatelyNEWS.md
under the header# admiralpeds (development version)
if the changes pertain to a user-facing function (i.e. it has an@export
tag) or documentation aimed at users (rather than developers)pkgdown::build_site()
and check that all affected examples are displayed correctly and that all new functions occur on the Reference page.lintr::lint_package()
R CMD check
locally and address all errors and warnings -devtools::check()