Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NEWS.md #97

Closed
wants to merge 2 commits into from
Closed

Update NEWS.md #97

wants to merge 2 commits into from

Conversation

remikk
Copy link
Contributor

@remikk remikk commented Oct 16, 2024

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the main branch until you have checked off each task.

  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
  • Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
  • Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
  • If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
  • Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
  • Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
  • Address any updates needed for vignettes and/or templates
  • Update NEWS.md under the header # admiralpeds (development version) if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
  • Build admiralpeds site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the Reference page.
  • Address or fix all lintr warnings and errors - lintr::lint_package()
  • Run R CMD check locally and address all errors and warnings - devtools::check()
  • Link the issue in the Development Section on the right hand side.
  • Address all merge conflicts and resolve appropriately
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

Copy link
Contributor

@Fanny-Gautier Fanny-Gautier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NEWS.md looks good, but there is an error with the vignette since the SDTMs have been moved.
image

I'll check next week whether this is corrected with Zelos PRs.

@rossfarrugia
Copy link
Collaborator

@remikk no need to create a separate branch and PR to update NEWS file. You should add this to the branch/PR you already opened here: #96. Then we can just merge one, and this one can be closed.

@Fanny-Gautier if we missed anything in the vignette from the test data updates do you want to make a separate issue/PR for that one? then Remi can focus only on the change from baseline update with his PR.

@Fanny-Gautier
Copy link
Contributor

@Fanny-Gautier if we missed anything in the vignette from the test data updates do you want to make a separate issue/PR for that one? then Remi can focus only on the change from baseline update with his PR.

Hi @rossfarrugia , investigating what's going on is on my to do list for this week ;-) thanks

Copy link
Contributor

@Fanny-Gautier Fanny-Gautier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now: build_site() issue has been fixed with Zelos' PR. Ready to merge... from the other branch and PR as suggested by Ross!

Copy link

github-actions bot commented Nov 6, 2024

Code Coverage

Package Line Rate Health
admiralpeds 99%
Summary 99% (267 / 271)

@Fanny-Gautier
Copy link
Contributor

@remikk no need to create a separate branch and PR to update NEWS file. You should add this to the branch/PR you already opened here: #96. Then we can just merge one, and this one can be closed.

Hi @remikk,
Happy New Year! ✨
Would it be possible to make this NEWSupdate on the same branch/PR you already opened here: #96, by the 15th Jan 2025? We could thus proceed with the release of {admiralpeds} after the core {admiral} package. Please let me know if not possible, and we would take it over from you.
Thanks.

@remikk remikk closed this Jan 7, 2025
@remikk remikk mentioned this pull request Jan 7, 2025
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants