chore(dependencies): upgrade liquibase to 4.27.0 #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 22, 2024
Merged
kirangodishala
force-pushed
the
liquibase-4-27-0-upgrade
branch
from
d8c5fc1 to
61b2f8e
Compare
nemesisOsorio
approved these changes
Jun 4, 2024
dbyron-sf
approved these changes
Jun 6, 2024
dbyron-sf
added a commit
to dbyron-sf/kork
that referenced
this pull request
Jun 6, 2024
)" This reverts commit 4ff407e. Turns out that we don't need liquibase 4.27.0 to fix migration issues with postgres. spinnaker/clouddriver#6217 fixes the migration with 4.24.0.
mergify bot
pushed a commit
that referenced
this pull request
Jun 7, 2024
) This reverts commit 4ff407e. Turns out that we don't need liquibase 4.27.0 to fix migration issues with postgres. spinnaker/clouddriver#6217 fixes the migration with 4.24.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
postgresql not supporting
afterColumnfeature and various issues with liquibase versions resulted in delayed liquibase upgrade from 3.10.3 to 4.24.0 in spinnaker 1.33.0 release. Here is the PR- #1117But even after the upgrade, migrating databases faced checksum issues.
In order to fix this issue two changes are needed.
Some background:
Broken Sprinnaker upgrades
Kork 7.201.0 upgraded liquibase to 4.24.0. And this is causing checkSum error for spinnaker upgrades. So all the releases starting from 1.33.0(1.33.0, 1.33.1, 1.33.2, 1.34.0, 1.34.1 and 1.34.2) are broken for Spinnaker upgrades.
Broken new Spinnaker Installation when Clouddriver uses Postgresql
Post liquibase 4.24.0 upgrade, due to lack of changes from spinnaker/clouddriver#6194, releases 1.33.0, 1.33.1, 1.34.0 and 1.34.1 would fail for new spinnaker installation if clouddriver uses Postgres and the error being "addAfterColumn is not allowed on postgresql". After including the changes 1.33.2 and 1.34.2 have no issues for new spinnaker installation.
So when the current fixes are merged and released, the versions 1.35.0, 1.33.3 and 1.34.3 and all later versions will work for both new installation and upgrade of Spinnaker.