-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(liquibase): fix checkSum errors occurring with spinnaker upgrade #4727
Merged
mergify
merged 2 commits into
spinnaker:master
from
kirangodishala:liquibase-checksum-fix
Jun 11, 2024
Merged
fix(liquibase): fix checkSum errors occurring with spinnaker upgrade #4727
mergify
merged 2 commits into
spinnaker:master
from
kirangodishala:liquibase-checksum-fix
Jun 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirangodishala
force-pushed
the
liquibase-checksum-fix
branch
from
May 22, 2024 17:53
30d3707
to
224750b
Compare
@Mergifyio update |
✅ Branch has been successfully updated |
kirangodishala
force-pushed
the
liquibase-checksum-fix
branch
from
June 10, 2024 16:58
464a34c
to
3e180cd
Compare
dbyron-sf
reviewed
Jun 10, 2024
orca-integration/src/test/java/com/netflix/spinnaker/orca/PostgresMigrationContainerTest.java
Outdated
Show resolved
Hide resolved
kirangodishala
force-pushed
the
liquibase-checksum-fix
branch
from
June 10, 2024 17:06
3e180cd
to
8606d8f
Compare
…sMigrationContainerTest
kirangodishala
force-pushed
the
liquibase-checksum-fix
branch
from
June 10, 2024 17:08
8606d8f
to
41d5f30
Compare
dbyron-sf
reviewed
Jun 10, 2024
orca-sql/src/main/resources/db/changelog/20200327-deleted-executions-table.yml
Show resolved
Hide resolved
dbyron-sf
approved these changes
Jun 11, 2024
@Mergifyio backport release-1.33.x release-1.34.x |
✅ Backports have been created
|
mergify bot
added a commit
that referenced
this pull request
Jun 12, 2024
…4727) (#4744) * fix(tests): Add new integration test for postgres migration - PostgresMigrationContainerTest * fix(liquibase): Fix validChecksum errors occurred due to liquibase upgrade (cherry picked from commit c5e7aad) Co-authored-by: Kiran Godishala <53332225+kirangodishala@users.noreply.github.com>
mergify bot
added a commit
that referenced
this pull request
Jun 12, 2024
…4727) (#4743) * fix(tests): Add new integration test for postgres migration - PostgresMigrationContainerTest * fix(liquibase): Fix validChecksum errors occurred due to liquibase upgrade (cherry picked from commit c5e7aad) Co-authored-by: Kiran Godishala <53332225+kirangodishala@users.noreply.github.com>
sanopsmx
pushed a commit
to OpsMx/orca-oes
that referenced
this pull request
Jul 12, 2024
…pinnaker#4727) (spinnaker#4743) * fix(tests): Add new integration test for postgres migration - PostgresMigrationContainerTest * fix(liquibase): Fix validChecksum errors occurred due to liquibase upgrade (cherry picked from commit c5e7aad) Co-authored-by: Kiran Godishala <53332225+kirangodishala@users.noreply.github.com> # Conflicts: # orca-integration/src/test/java/com/netflix/spinnaker/orca/BaseContainerTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto merged
Merged automatically by a bot
ready to merge
Approved and ready for merge
target-release/1.35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new integration test to validate the postgres migration scenario which uses latest 1.32.x image(us-docker.pkg.dev/spinnaker-community/docker/orca:8.36.3-dev-release-1.32.x-3f8965d03-202406101625-unvalidated) as base image.
This PR fixes checkSum errors caused after liquibase upgrade(to 4.24.0) as the checksum calculations in liquibase underwent some changes causing this issue.
This PR fixes the checksum errors by adding validChecksum tags to the failing changesets.
Similar clouddriver PR for reference: spinnaker/clouddriver#6217