Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(liquibase): fix checkSum errors occurring with spinnaker upgrade #4727

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

kirangodishala
Copy link
Contributor

@kirangodishala kirangodishala commented May 22, 2024

Added new integration test to validate the postgres migration scenario which uses latest 1.32.x image(us-docker.pkg.dev/spinnaker-community/docker/orca:8.36.3-dev-release-1.32.x-3f8965d03-202406101625-unvalidated) as base image.

This PR fixes checkSum errors caused after liquibase upgrade(to 4.24.0) as the checksum calculations in liquibase underwent some changes causing this issue.

This PR fixes the checksum errors by adding validChecksum tags to the failing changesets.

Similar clouddriver PR for reference: spinnaker/clouddriver#6217

@dbyron-sf
Copy link
Contributor

@Mergifyio update

Copy link
Contributor

mergify bot commented Jun 7, 2024

update

✅ Branch has been successfully updated

@kirangodishala kirangodishala force-pushed the liquibase-checksum-fix branch from 464a34c to 3e180cd Compare June 10, 2024 16:58
@kirangodishala kirangodishala force-pushed the liquibase-checksum-fix branch from 3e180cd to 8606d8f Compare June 10, 2024 17:06
@kirangodishala kirangodishala force-pushed the liquibase-checksum-fix branch from 8606d8f to 41d5f30 Compare June 10, 2024 17:08
@dbyron-sf
Copy link
Contributor

@Mergifyio backport release-1.33.x release-1.34.x

Copy link
Contributor

mergify bot commented Jun 12, 2024

backport release-1.33.x release-1.34.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jun 12, 2024
…4727)

* fix(tests): Add new integration test for postgres migration - PostgresMigrationContainerTest

* fix(liquibase): Fix validChecksum errors occurred due to liquibase upgrade

(cherry picked from commit c5e7aad)
mergify bot pushed a commit that referenced this pull request Jun 12, 2024
…4727)

* fix(tests): Add new integration test for postgres migration - PostgresMigrationContainerTest

* fix(liquibase): Fix validChecksum errors occurred due to liquibase upgrade

(cherry picked from commit c5e7aad)
mergify bot added a commit that referenced this pull request Jun 12, 2024
…4727) (#4744)

* fix(tests): Add new integration test for postgres migration - PostgresMigrationContainerTest

* fix(liquibase): Fix validChecksum errors occurred due to liquibase upgrade

(cherry picked from commit c5e7aad)

Co-authored-by: Kiran Godishala <53332225+kirangodishala@users.noreply.github.com>
mergify bot added a commit that referenced this pull request Jun 12, 2024
…4727) (#4743)

* fix(tests): Add new integration test for postgres migration - PostgresMigrationContainerTest

* fix(liquibase): Fix validChecksum errors occurred due to liquibase upgrade

(cherry picked from commit c5e7aad)

Co-authored-by: Kiran Godishala <53332225+kirangodishala@users.noreply.github.com>
sanopsmx pushed a commit to OpsMx/orca-oes that referenced this pull request Jul 12, 2024
…pinnaker#4727) (spinnaker#4743)

* fix(tests): Add new integration test for postgres migration - PostgresMigrationContainerTest

* fix(liquibase): Fix validChecksum errors occurred due to liquibase upgrade

(cherry picked from commit c5e7aad)

Co-authored-by: Kiran Godishala <53332225+kirangodishala@users.noreply.github.com>
# Conflicts:
#	orca-integration/src/test/java/com/netflix/spinnaker/orca/BaseContainerTest.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merged Merged automatically by a bot ready to merge Approved and ready for merge target-release/1.35
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants