pscanrulesAlpha: Link website alert pages <-> help #5094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thc202
changed the title
|
The changes look good. |
|
Oh, and to fix the tests: |
psiinon
reviewed
Nov 15, 2023
Signed-off-by: amitpanwar789 <amitpanwar02705@gmail.com>
Signed-off-by: amitpanwar789 <amitpanwar02705@gmail.com>
Signed-off-by: amitpanwar789 <amitpanwar02705@gmail.com>
amitpanwar789
force-pushed
the
alert_page
branch
from
3660062 to
baa9d95
Compare
psiinon
reviewed
Nov 15, 2023
...n/javahelp/org/zaproxy/zap/extension/pscanrulesAlpha/resources/help/contents/pscanalpha.html
Outdated
Show resolved
Hide resolved
Signed-off-by: amitpanwar789 <amitpanwar02705@gmail.com>
8 tasks
psiinon
approved these changes
Nov 16, 2023
thc202
reviewed
Nov 16, 2023
...n/javahelp/org/zaproxy/zap/extension/pscanrulesAlpha/resources/help/contents/pscanalpha.html
Outdated
Show resolved
Hide resolved
Signed-off-by: thc202 <thc202@gmail.com>
thc202
approved these changes
Nov 16, 2023
|
@amitpanwar789 thank you! How would you like to be credited (e.g. name, handle)? |
|
@amitpanwar789 ping (it's fine if you don't want to, just making sure this was not missed). |
|
thanks for ping, (Amit Panwar, amitpanwar789) this would be good. |
thc202
added a commit
to thc202/zap-core-help
that referenced
this pull request
Nov 28, 2023
From zaproxy/zap-extensions#5094. Signed-off-by: thc202 <thc202@gmail.com>
8 tasks
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
added getHelpLink method in Base64Disclosure.java and FetchMetadataRequestHeadersScanRule.java
added anchor tag for respective method in pscanalpha.html
Related Issues
This PR is part of issue #8189
@psiinon can you please review it
Added
Checklist
./gradlew spotlessApplyfor code formattingFor more details, please refer to the developer rules and guidelines.