Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client for new ipex admit API and updated issue-ecr.sh to work with IPEX #93

Merged
merged 4 commits into from
Nov 6, 2023

Conversation

pfeairheller
Copy link
Member

This PR includes:

  • Client for new ipex admit API and updated issue-ecr.sh to work with IPEX

Signed-off-by: pfeairheller <pfeairheller@gmail.com>
Signed-off-by: pfeairheller <pfeairheller@gmail.com>
Signed-off-by: pfeairheller <pfeairheller@gmail.com>
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #93 (2dfd107) into development (6246421) will increase coverage by 0.66%.
Report is 2 commits behind head on development.
The diff coverage is 100.00%.

@@               Coverage Diff               @@
##           development      #93      +/-   ##
===============================================
+ Coverage        89.27%   89.94%   +0.66%     
===============================================
  Files               16       16              
  Lines              998     1004       +6     
===============================================
+ Hits               891      903      +12     
+ Misses             107      101       -6     
Files Coverage Δ
src/signify/app/credentialing.py 93.70% <100.00%> (+0.20%) ⬆️
src/signify/core/authing.py 57.38% <100.00%> (+3.93%) ⬆️
src/signify/peer/exchanging.py 100.00% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Signed-off-by: pfeairheller <pfeairheller@gmail.com>
@pfeairheller pfeairheller merged commit ba43e15 into WebOfTrust:development Nov 6, 2023
4 checks passed
@pfeairheller pfeairheller deleted the fix-ecr-sample branch November 6, 2023 21:21
Copy link

@kentbull kentbull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants