Feature 431. Migrate to AG Grid and direct streaming #463
Conversation
This will let the component that uses the hook handle the error with more flexibility and accessibility
It is required if the streaming is used outside the AG Grid implementation
This will provide better flexibility in using it within UI
src/component-library/tailwind.css
Outdated
| } | ||
|
|
||
| /*@layer base {*/ |
There was a problem hiding this comment.
@MytsV any reason to keep these commented css styles here?
There was a problem hiding this comment.
Are storybooks able to pick up the ag-grid-rucio css file?
There was a problem hiding this comment.
Sorry, that's still a WIP and something got left from connecting shadcn/ui. I'll review it when working on the toasts in this PR.
@MytsV any reason to keep these commented css styles here?
There was a problem hiding this comment.
Are storybooks able to pick up the ag-grid-rucio css file?
Yes, and, luckily, without any additional setup!
…cover it by tests
|
The basic parts for migrating to it everywhere are included here. On top of these changes, pages will be rebuilt |
|
The new version of the streaming is the best of both worlds. While the previous implementation still experienced performance issues with receiving large amounts of data in a short time, ComDOM fetched it fast at least inside the worker. Therefore I decided to try it out with a worker and it turned out great. My idea was to make it as basic as possible, so there's less room for bugs. Communication between threads is done via messages instead of method calls. There are no apparent issues neither with state management nor with loading at any rate. Benchmarks will be set up during the individual work on each page. |
|
As the AG Grid styling doesn't use tailwind, it has to rely on a color mode observer to change it's theme together with tailwind components. |
|
Current light vs dark theme of the table: |
|
I don't like how the code of streamWorker.js turned out and will refactor it, but currently I'm too scared to break something. So I'll cover some page with integration tests first :) P. S. The unit tests for the hook had to go as they don't support web workers! |
|
These changes are included in #477 |
There are still a lot of pending improvements to the table and generally the UI. I need a little time to come up with a new design to make more changes to the responsiveness and appearance.